fix(go): tolerate numeric ping timestamps - #2198
Closed
xianjianlf2 wants to merge 1 commit into
Closed
Conversation
xianjianlf2
marked this pull request as ready for review
August 1, 2026 08:23
Contributor
|
Thanks for the contribution, @xianjianlf2. However since we don't support using mismatched SDK and runtime versions (especially not radically mismatches ones as in this issue), it's not something we'd want to add support for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1356.
Summary
PingResponseand generatedrpc.PingResultaccept ISO-8601 timestamps, numeric epoch milliseconds, and stringified epoch millisecondsRoot cause
The Go SDK models ping timestamps as
time.Time, which accepts ISO-8601 strings but rejects older numeric epoch-millisecond payloads from some CLI builds. That can make startup fail during protocol verification before callers can issue any SDK requests.Validation
go test . ./rpcgo test ./...was also run; non-E2E packages passed, butgo/internal/e2efailed because this checkout does not have the Copilot CLI package installed undernodejs/node_modules/@github/copilot-*/index.js.